[llvm] r194769 - [llvm-c] Simplify signature of LLVMGetTargetFromName

Peter Zotov whitequark at whitequark.org
Thu Nov 14 18:51:02 PST 2013


Author: whitequark
Date: Thu Nov 14 20:51:01 2013
New Revision: 194769

URL: http://llvm.org/viewvc/llvm-project?rev=194769&view=rev
Log:
[llvm-c] Simplify signature of LLVMGetTargetFromName

LLVMGetTargetFromName was not yet present in an LLVM release,
so this does not break compatibility.

Modified:
    llvm/trunk/include/llvm-c/TargetMachine.h
    llvm/trunk/lib/Target/TargetMachineC.cpp

Modified: llvm/trunk/include/llvm-c/TargetMachine.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm-c/TargetMachine.h?rev=194769&r1=194768&r2=194769&view=diff
==============================================================================
--- llvm/trunk/include/llvm-c/TargetMachine.h (original)
+++ llvm/trunk/include/llvm-c/TargetMachine.h Thu Nov 14 20:51:01 2013
@@ -64,7 +64,7 @@ LLVMTargetRef LLVMGetNextTarget(LLVMTarg
 /*===-- Target ------------------------------------------------------------===*/
 /** Finds the target corresponding to the given name and stores it in \p T. 
   Returns 0 on success. */
-LLVMBool LLVMGetTargetFromName(const char *Name, LLVMTargetRef *T);
+LLVMTargetRef LLVMGetTargetFromName(const char *Name);
 
 /** Finds the target corresponding to the given triple and stores it in \p T.
   Returns 0 on success. Optionally returns any error in ErrorMessage.

Modified: llvm/trunk/lib/Target/TargetMachineC.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetMachineC.cpp?rev=194769&r1=194768&r2=194769&view=diff
==============================================================================
--- llvm/trunk/lib/Target/TargetMachineC.cpp (original)
+++ llvm/trunk/lib/Target/TargetMachineC.cpp Thu Nov 14 20:51:01 2013
@@ -72,17 +72,14 @@ LLVMTargetRef LLVMGetNextTarget(LLVMTarg
   return wrap(unwrap(T)->getNext());
 }
 
-LLVMBool LLVMGetTargetFromName(const char *Name, LLVMTargetRef *T) {
+LLVMTargetRef LLVMGetTargetFromName(const char *Name) {
   for (TargetRegistry::iterator IT = TargetRegistry::begin(),
                                 IE = TargetRegistry::end(); IT != IE; ++IT) {
-    if (IT->getName() == Name) {
-      *T = wrap(&*IT);
-
-      return 0;
-    }
+    if (IT->getName() == Name)
+      return wrap(&*IT);
   }
   
-  return 1;
+  return NULL;
 }
 
 LLVMBool LLVMGetTargetFromTriple(const char* TripleStr, LLVMTargetRef *T,





More information about the llvm-commits mailing list