[llvm] r194747 - Add #include raw_ostream.h in lib/Target/R600/SIFixSGPRCopies.cpp

[Eric Christopher]

On Thu, Nov 14, 2013 at 3:36 PM, Rui Ueyama <ruiu at google.com> wrote:
> On Thu, Nov 14, 2013 at 3:24 PM, Hans Wennborg <hans at hanshq.net> wrote:
>>
>> Author: hans
>> Date: Thu Nov 14 17:24:09 2013
>> New Revision: 194747
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=194747&view=rev
>> Log:
>> Add #include raw_ostream.h in lib/Target/R600/SIFixSGPRCopies.cpp
>>
>> This was casuing my release+asserts build on Windows to fail.
>
>
> I think Debug.h practically depends on raw_ostream.h. Including only Debug.h
> won't raise a compilation error, but you cannot do anything (like writing
> something with <<) to raw_ostream objects returned from llvm::dbgs() or
> llvm::err() without the header. Should we include raw_ostream.h from
> Debug.h?

I think so. I've been meaning to make that case for a couple of years
now, but keep getting distracted.

-eric

>
>> Modified:
>>     llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp
>>
>> Modified: llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp?rev=194747&r1=194746&r2=194747&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp (original)
>> +++ llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp Thu Nov 14 17:24:09
>> 2013
>> @@ -72,6 +72,7 @@
>>  #include "llvm/CodeGen/MachineInstrBuilder.h"
>>  #include "llvm/CodeGen/MachineRegisterInfo.h"
>>  #include "llvm/Support/Debug.h"
>> +#include "llvm/Support/raw_ostream.h"
>>  #include "llvm/Target/TargetMachine.h"
>>
>>  using namespace llvm;
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>