[patch] Reject alias to declarations in ELF and COFF

Bob Wilson bob.wilson at apple.com
Wed Nov 13 15:13:22 PST 2013

I’m not familiar with N_INDR, but if it is not supported by the latest shipping version of OS X, then we shouldn’t have anything in LLVM that depends on it.  Even then, it would be best to have a configure check to enable it.

On Nov 13, 2013, at 2:53 PM, Eric Christopher <echristo at gmail.com> wrote:

> Makes sense. You should probably elaborate in the commit message about
> such things.
> I'd probably just disable it for all targets and MachO can turn it on
> when they actually ship/enable that support, but I'll let Bob make
> that call.
> Otherwise it's fine.
> -eric
> On Wed, Nov 13, 2013 at 2:42 PM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
>> On 13 November 2013 17:23, Eric Christopher <echristo at gmail.com> wrote:
>>> Looks like the majority of the change here is updating testcases
>>> after? Can you elaborate a bit?
>> Sure, the test changes are just converting declarations to
>> definitions. Most of these tests are from when we used aliases to
>> declarations to implement weakref.
>> Cheers,
>> Rafael

More information about the llvm-commits mailing list