[llvm] r194604 - Revert my CMake patches concerning building with /MT (r194589, r194596)

Hans Wennborg hans at hanshq.net
Wed Nov 13 12:29:10 PST 2013


Author: hans
Date: Wed Nov 13 14:29:10 2013
New Revision: 194604

URL: http://llvm.org/viewvc/llvm-project?rev=194604&view=rev
Log:
Revert my CMake patches concerning building with /MT (r194589, r194596)

Reid pointed out we already have LLVM_USE_CRT_{buildtype} to set it.

Modified:
    llvm/trunk/CMakeLists.txt
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
    llvm/trunk/docs/CMake.rst

Modified: llvm/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=194604&r1=194603&r2=194604&view=diff
==============================================================================
--- llvm/trunk/CMakeLists.txt (original)
+++ llvm/trunk/CMakeLists.txt Wed Nov 13 14:29:10 2013
@@ -17,8 +17,6 @@ set(PACKAGE_VERSION "${LLVM_VERSION_MAJO
 
 option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in the 'install' target." OFF)
 
-option(LLVM_STATIC_MSVC_RUNTIME "When using MSVC, link against the static run-time (/MT)" OFF)
-
 option(LLVM_USE_FOLDERS "Enable solution folders in Visual Studio. Disable for Express versions." ON)
 if ( LLVM_USE_FOLDERS )
   set_property(GLOBAL PROPERTY USE_FOLDERS ON)

Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=194604&r1=194603&r2=194604&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Wed Nov 13 14:29:10 2013
@@ -5,7 +5,6 @@
 include(AddLLVMDefinitions)
 include(CheckCCompilerFlag)
 include(CheckCXXCompilerFlag)
-include(LLVMProcessSources)
 
 if( CMAKE_COMPILER_IS_GNUCXX )
   set(LLVM_COMPILER_IS_GCC_COMPATIBLE ON)
@@ -41,18 +40,6 @@ else()
   endif()
 endif()
 
-if(MSVC AND LLVM_STATIC_MSVC_RUNTIME)
-  # Link against the static runtime.
-  foreach(flag CMAKE_C_FLAGS_RELEASE CMAKE_C_FLAGS_RELWITHDEBINFO
-      CMAKE_C_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_RELEASE
-      CMAKE_CXX_FLAGS_RELWITHDEBINFO CMAKE_CXX_FLAGS_MINSIZEREL)
-    llvm_replace_compiler_option("${flag}" "/MD" "/MT")
-  endforeach()
-  foreach(flag CMAKE_C_FLAGS_DEBUG CMAKE_CXX_FLAGS_DEBUG)
-    llvm_replace_compiler_option("${flag}" "/MDd" "/MTd")
-  endforeach()
-endif()  
-
 if(WIN32)
   if(CYGWIN)
     set(LLVM_ON_WIN32 0)

Modified: llvm/trunk/docs/CMake.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/CMake.rst?rev=194604&r1=194603&r2=194604&view=diff
==============================================================================
--- llvm/trunk/docs/CMake.rst (original)
+++ llvm/trunk/docs/CMake.rst Wed Nov 13 14:29:10 2013
@@ -280,11 +280,6 @@ LLVM-specific variables
   are ``Address``, ``Memory`` and ``MemoryWithOrigins``. Defaults to empty
   string.
 
-**LLVM_STATIC_MSVC_RUNTIME**:BOOL
-  When building with MSVC, link against the static runtime library (/MT or /MTd
-  for release and debug builds, respectively) instead of the dynamic one.
-  Defaults to OFF.
-
 Executing the test suite
 ========================
 





More information about the llvm-commits mailing list