[PATCH] Fix illegal DAG produced by SelectionDAG::getConstant() for v2i64 type

David Blaikie dblaikie at gmail.com
Wed Nov 13 09:18:40 PST 2013

On Wed, Nov 13, 2013 at 4:03 AM, Daniel Sanders
<daniel.sanders at imgtec.com>wrote:

>   Can I check a matter of policy?
>   Is it ok to commit the version of the patch you LGTM'd and then fix the
> MIPS-specific false passes (caused by the missing 'virtual' keyword) under
> the 'obvious change' rule? or should I wait for an explicit LGTM on the
> updated patch?

Generally if someone says "LGTM as long as you do blah" you're entrusted to
make those changes in your current patch and commit in one go without
further review. If for some reason you got the requested changes wrong,
they'll generally be addressed in post-commit review (which, if the
wrongness was sufficiently severe, could include reverting, but that's
usually uncommon/unlikely as such extra changes are usually
simple/mechanical in nature)

>   I don't mind either way. I just want to double-check what I should be
> doing for this patch.
>   Thanks
> http://llvm-reviews.chandlerc.com/D1973
>   msa/bugfix-getconstant2
>   llvm
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131113/d0ea19db/attachment.html>

More information about the llvm-commits mailing list