[PATCH] Implement aarch64 neon instruction class SIMD Table lookup - LLVM

Jiangning Liu liujiangning1 at gmail.com
Wed Nov 13 02:44:47 PST 2013


  I modified the code by moving the lowering from backend to frontend, and hopefully this is what you meant.


Comment at: lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:737-738
@@ +736,4 @@
+    SDValue IDef =
+        SDValue(CurDAG->getMachineNode(TargetOpcode::IMPLICIT_DEF, Ops[PairPos],
+                                       Ops[PairPos].getValueType()),
+                0);
Tim Northover wrote:
> Reading the descriptions, I think this probably has to be a zero-vector rather than IMPLICIT_DEF to match the AArch64 VTBL semantics (and can't match VTBX semantics no matter what you do).
> The issue is:
>    vtbx.8 d0, {d1}, d2
> If d2[0] = 8 then the AArch32 instruction will leave d0[0] unchanged. However:
>     tbx v0.16b, {v1.16b}, v2.16b
> will set it to v1.16b[8]. I don't think these can be reconciled without real pre or post-processing.
I modified code and moved lowering from backend to frontend, so this piece of code is moved to CGBuiltin.cpp.

Comment at: lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:699
@@ -684,1 +698,3 @@
+SDNode *AArch64DAGToDAGISel::combine2D(SDLoc dl, SDValue D0, SDValue D1) {
+  SDValue idef = SDValue(CurDAG->getMachineNode(TargetOpcode::IMPLICIT_DEF,
Tim Northover wrote:
> Longer term, it would be nice if this could just be a CONCAT_VECTORS operation. It doesn't look like we've got the patterns for that yet though, so this isn't too bad in the meantime.
OK. In CGBuiltin.cpp, I modified code to use shuffle_vector and finally it should be able to automatically generate concat_vectors.

Comment at: lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:799-803
@@ +798,7 @@
+  EVT ResVT = N->getValueType(0);
+  bool is64BitRes;
+  switch (ResVT.getSimpleVT().SimpleTy) {
+  default: llvm_unreachable("unhandled table look up result type");
+  case MVT::v8i8  : is64BitRes = true; break;
+  case MVT::v16i8 : is64BitRes = false; break;
+  }
Tim Northover wrote:
> bool Is64BitRes = ResVT.is64BitVector();
> ?
OK. I will make that change.

Comment at: lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:973
@@ -837,3 +972,3 @@
-    return SelectVLD(Node, 1, true, Opcodes);
+    return selectVLD(Node, 1, true, Opcodes);
Tim Northover wrote:
> Good idea, but probably a separate patch. Could you go ahead and commit it as a refactor?
OK. I reversed this change.


More information about the llvm-commits mailing list