[lld] r194552 - Revert "Use empty() instead of size() == 0."

Rui Ueyama ruiu at google.com
Tue Nov 12 19:30:29 PST 2013


Author: ruiu
Date: Tue Nov 12 21:30:29 2013
New Revision: 194552

URL: http://llvm.org/viewvc/llvm-project?rev=194552&view=rev
Log:
Revert "Use empty() instead of size() == 0."

This reverts commit r194551 because it broke the buildbot.

Modified:
    lld/trunk/lib/Core/Resolver.cpp
    lld/trunk/lib/Driver/InputGraph.cpp
    lld/trunk/lib/Driver/WinLinkDriver.cpp
    lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h
    lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp
    lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp

Modified: lld/trunk/lib/Core/Resolver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/Resolver.cpp?rev=194552&r1=194551&r2=194552&view=diff
==============================================================================
--- lld/trunk/lib/Core/Resolver.cpp (original)
+++ lld/trunk/lib/Core/Resolver.cpp Tue Nov 12 21:30:29 2013
@@ -227,7 +227,7 @@ void Resolver::doDefinedAtom(const Defin
   switch ( atom.sectionPosition() ) {
   case DefinedAtom::sectionPositionStart:
   case DefinedAtom::sectionPositionEnd:
-    assert(atom.empty());
+    assert(atom.size() == 0);
     break;
   case DefinedAtom::sectionPositionEarly:
   case DefinedAtom::sectionPositionAny:

Modified: lld/trunk/lib/Driver/InputGraph.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/InputGraph.cpp?rev=194552&r1=194551&r2=194552&view=diff
==============================================================================
--- lld/trunk/lib/Driver/InputGraph.cpp (original)
+++ lld/trunk/lib/Driver/InputGraph.cpp Tue Nov 12 21:30:29 2013
@@ -133,7 +133,7 @@ uint32_t ControlNode::getResolveState()
 /// \brief Set the resolve state for the current element
 /// thats processed by the resolver.
 void ControlNode::setResolveState(uint32_t resolveState) {
-  if (_elements.empty())
+  if (_elements.size() == 0)
     return;
   _elements[_currentElementIndex]->setResolveState(resolveState);
 }
@@ -151,7 +151,7 @@ SimpleFileNode::SimpleFileNode(StringRef
 /// of the input elements contained in the group.
 ErrorOr<File &> Group::getNextFile() {
   // If there are no elements, move on to the next input element
-  if (_elements.empty())
+  if (_elements.size() == 0)
     return make_error_code(InputGraphError::no_more_files);
 
   for (;;) {

Modified: lld/trunk/lib/Driver/WinLinkDriver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkDriver.cpp?rev=194552&r1=194551&r2=194552&view=diff
==============================================================================
--- lld/trunk/lib/Driver/WinLinkDriver.cpp (original)
+++ lld/trunk/lib/Driver/WinLinkDriver.cpp Tue Nov 12 21:30:29 2013
@@ -911,7 +911,7 @@ WinLinkDriver::parse(int argc, const cha
     }
   }
 
-  if (inputElements.empty() && !isReadingDirectiveSection) {
+  if (inputElements.size() == 0 && !isReadingDirectiveSection) {
     diagnostics << "No input files\n";
     return false;
   }

Modified: lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h?rev=194552&r1=194551&r2=194552&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h Tue Nov 12 21:30:29 2013
@@ -576,7 +576,7 @@ StringTable<ELFT>::StringTable(const ELF
 
 template <class ELFT> uint64_t StringTable<ELFT>::addString(StringRef symname) {
 
-  if (symname.empty())
+  if (symname.size() == 0)
     return 0;
   StringMapTIter stringIter = _stringMap.find(symname);
   if (stringIter == _stringMap.end()) {

Modified: lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp?rev=194552&r1=194551&r2=194552&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp (original)
+++ lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp Tue Nov 12 21:30:29 2013
@@ -123,7 +123,7 @@ public:
 
   virtual void addStubAtoms(MutableFile &mergedFile) {
     // Exit early if no stubs needed.
-    if (_targetToStub.empty())
+    if ( _targetToStub.size() == 0 )
       return;
     // Add all stubs to master file.
     for (auto it : _targetToStub) {

Modified: lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=194552&r1=194551&r2=194552&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp (original)
+++ lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp Tue Nov 12 21:30:29 2013
@@ -666,7 +666,7 @@ private:
       array = array.slice(3);
     }
 
-    if (array.empty())
+    if (array.size() == 0)
       return "";
 
     size_t len = 0;





More information about the llvm-commits mailing list