[lld] r194539 - [PECOFF] Do not print error if length of .drectve is 0.

[Rui Ueyama]

 On Tue, Nov 12, 2013 at 7:03 PM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
>
> On Tue, Nov 12, 2013 at 5:19 PM, Rui Ueyama <ruiu at google.com> wrote:
>
>> Author: ruiu
>> Date: Tue Nov 12 19:19:08 2013
>> New Revision: 194539
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=194539&view=rev
>> Log:
>> [PECOFF] Do not print error if length of .drectve is 0.
>>
>> Modified:
>>     lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
>>
>> Modified: lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=194539&r1=194538&r2=194539&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp (original)
>> +++ lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp Tue Nov 12 19:19:08
>> 2013
>> @@ -666,6 +666,9 @@ private:
>>        array = array.slice(3);
>>      }
>>
>> +    if (array.size() == 0)
>>
>
> Usually we'd write this as "array.empty()"
>

Fixed in r194550.


>
>
 +      return "";
>> +
>>      size_t len = 0;
>>      size_t e = array.size();
>>      while (len < e && array[len] != '\0')
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131112/8923ae5f/attachment.html>