[PATCH] [OCaml] Dynamically link LLVM on --enable-shared builds

Sylvestre Ledru sylvestre at debian.org
Tue Nov 12 12:20:18 PST 2013



================
Comment at: bindings/ocaml/Makefile.ocaml:145
@@ +144,3 @@
+ifdef OCAMLSTUBS
+LibrarySO := $(OcamlDir)/dll$(LIBRARYNAME).so
+endif
----------------
I think you should use $(SHLIBEXT) instead of .so here
(for example, it is .dylib under Mac OS X)

Also, please rename LibrarySo for SharedLibrary or something like that

================
Comment at: bindings/ocaml/Makefile.ocaml:166
@@ +165,3 @@
+ifdef OCAMLSTUBS
+DestSO   := $(PROJ_libocamldir)/dll$(LIBRARYNAME).so
+endif
----------------
idem

================
Comment at: bindings/ocaml/Makefile.ocaml:230
@@ +229,3 @@
+all-local:: $(LibrarySO)
+clean-local:: clean-so
+install-local:: install-so
----------------
please rename *-so to *-shared


http://llvm-reviews.chandlerc.com/D2099



More information about the llvm-commits mailing list