[PATCH] [ASan] Do not rely on malloc context in allocator reports

Alexey Samsonov samsonov at google.com
Tue Nov 12 08:22:14 PST 2013


  LGTM modulo nits below. Let me know if I should commit this for you.


================
Comment at: lib/sanitizer_common/sanitizer_stacktrace.h:49
@@ -47,3 +48,3 @@
       trace[i] = src[i];
   }
 
----------------
top_frame_bp = 0;

================
Comment at: lib/asan/lit_tests/TestCases/Linux/malloc_delete_mismatch.cc:8
@@ -7,2 +7,3 @@
 // No error here.
-// RUN: ASAN_OPTIONS=alloc_dealloc_mismatch=0 %t
+// RUN: ASAN_OPTIONS=alloc_dealloc_mismatch=0 %t --check-prefix=CHECK-CTX
+
----------------
no need in --check-prefix here, as FileCheck is not invoked.


http://llvm-reviews.chandlerc.com/D2136



More information about the llvm-commits mailing list