[llvm] r194459 - Change data structure to memorize computed result in ScalarEvolution
chandlerc at google.com
Tue Nov 12 01:55:34 PST 2013
On Tue, Nov 12, 2013 at 1:40 AM, Wan Xiaofei <xiaofei.wan at intel.com> wrote:
> Author: xiaofei.wan
> Date: Tue Nov 12 03:40:41 2013
> New Revision: 194459
> URL: http://llvm.org/viewvc/llvm-project?rev=194459&view=rev
> Change data structure to memorize computed result in ScalarEvolution
> Replace std::map with SmallVector to memorize the cached result since SCEVusually belongs to little Loop/BB
> Linear scan on SmallVector is faster than std::map.
> Code reviewer : Andrew Trick.
Please revert this.
Andy never reviewed this on the mailing list. Hal gave one comment, which
you replied to, and no updates to the code review thread have occurred.
There was no code review or LGTM. =/ I really like the idea of this patch,
but you can't just bypass the code review process like this!
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits