[PATCH] Consider error-reporting calls cold in BPI

Hal Finkel hfinkel at anl.gov
Mon Nov 11 22:04:50 PST 2013

----- Original Message -----
> On Sat, Nov 9, 2013 at 5:44 AM, Hal Finkel < hfinkel at anl.gov > wrote:
> Okay, I've attached a patch that adds this into SimplifyLibCalls. In
> this incarnation, I've added the functionality at the top-level of
> SimplifyLibCalls itself (which makes it different from all of the
> other simplifications). My rationale for this is that adding the
> cold hint should not depend on the builtin status of the functions.
> I'm not sure how much I like this. Thoughts?
> I think it should depend on the builtin status of the functions. If
> we're in a freestanding environment, there is no reason to believe
> that the meanings for the various file descriptors continue to hold.

Chandler, Meador, et al.,

Thanks for your feedback! I've attached a new version (which makes this look much like all of the other optimizations). Please review.


Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory
-------------- next part --------------
A non-text attachment was scrubbed...
Name: slc-err-rep-v2.patch
Type: text/x-patch
Size: 8491 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131112/b06ebab6/attachment.bin>

More information about the llvm-commits mailing list