[PATCH] Avoid illegal integer promotion in X86FastISel

Eric Christopher echristo at gmail.com
Mon Nov 11 17:27:47 PST 2013


On Mon, Nov 11, 2013 at 5:24 PM, Chandler Carruth <chandlerc at google.com> wrote:
> Totally not an important comment for this review....
>
> On Mon, Nov 11, 2013 at 5:19 PM, Eric Christopher <echristo at gmail.com>
> wrote:
>>
>> +; RUN: llc %s -O0 -o - | FileCheck %s
>> +
>> +target triple = "armv7-apple-ios"
>>
>> Go ahead and fold the triple into RUN line for all of these.
>
>
> Why is that better? I'd actually prefer target being in the IR because then
> there is less to type when reproducing or debugging a failure.

Lacking a better answer "tradition!" for llc tests.

-eric



More information about the llvm-commits mailing list