[PATCH][ARM]Fix urem/srem of i64 for aeabi target (PR 17881)

[Renato Golin]

Hi Weiming,

I worked on this a bit in the past, and have attached both partial
solutions to your bug, as well as making my own bug a duplicate of yours,
so at least you can understand where we're coming from. Tim helped me
review the patches and understand the problem, so both of us will be
reviewing this.

thanks,
-renato


On 11 November 2013 22:03, Tim Northover <t.p.northover at gmail.com> wrote:

> Hi Weiming,
>
> > Please help to review the patch that addresses i64 mod operation for ARM
> > aeabi.
>
> Can this be done in ARM's ISelLowering? The problem is that ExpandRem
> is *only* the correct implementation for the ARM-specific __aeabi_*
> functions. The more generic GNU-style calls have a different
> prototype:
>
>    int64_t __divmoddi4(int64_t l, int64_t r, int64_t *rem);
>
> As it stands, any other target deciding to Expand divrem is likely to
> get a nasty shock.
>
> Cheers.
>
> Tim.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131111/32052be3/attachment.html>