[compiler-rt] r194331 - Remove a FIXME now that I can't reproduce the problem

Timur Iskhodzhanov timurrrr at google.com
Sat Nov 9 07:01:23 PST 2013


Author: timurrrr
Date: Sat Nov  9 09:01:23 2013
New Revision: 194331

URL: http://llvm.org/viewvc/llvm-project?rev=194331&view=rev
Log:
Remove a FIXME now that I can't reproduce the problem

Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc?rev=194331&r1=194330&r2=194331&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc Sat Nov  9 09:01:23 2013
@@ -383,8 +383,6 @@ void StackTrace::SlowUnwindStack(uptr pc
   size = CaptureStackBackTrace(2, Min(max_depth, kStackTraceMax),
                                (void**)trace, 0);
   // Skip the RTL frames by searching for the PC in the stacktrace.
-  // FIXME: this doesn't work well for the malloc/free stacks yet - consider
-  // adjusting the pc_threshold.
   uptr pc_location = LocatePcInTrace(pc);
   PopStackFrames(pc_location);
 }





More information about the llvm-commits mailing list