[llvm] r194300 - Rewrite the PBQP graph data structure.

Lang Hames lhames at gmail.com
Fri Nov 8 19:13:15 PST 2013


Odd - I didn't see any buildbot emails about this?

Thanks for the catch guys. I've fixed the issues and re-applied in r194311.

- Lang.



On Fri, Nov 8, 2013 at 6:05 PM, Nick Lewycky <nlewycky at google.com> wrote:

> Reverted in 194308.
>
>
> On 8 November 2013 17:07, Nick Lewycky <nlewycky at google.com> wrote:
>
>> On 8 November 2013 17:01, Rafael EspĂ­ndola <rafael.espindola at gmail.com>wrote:
>>
>>> looks like this is causing a -Werror build failure:
>>>
>>> include/llvm/CodeGen/PBQP/Graph.h:362:14: error: implicit conversion
>>> from 'type' (aka 'unsigned long') to 'EdgeId' (aka 'unsigned int')
>>> changes value from 18446744073709551615 to 4294967295
>>> [-Werror,-Wconstant-conversion]
>>>       return std::numeric_limits<EdgeVector::size_type>::max();
>>>
>>
>> and another:
>>
>> include/llvm/CodeGen/PBQP/Graph.h:150:17: error: inline function
>> 'PBQP::Graph::copyFrom' is not defined [-Werror,-Wundefined-inline]
>>      inline void copyFrom(const Graph &other);
>>                 ^
>> include/llvm/CodeGen/PBQP/Graph.h:212:7: note: used here
>>       copyFrom(other);
>>       ^
>> 1 error generated.
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131108/c87e0bb4/attachment.html>


More information about the llvm-commits mailing list