[PATCH] Consider error-reporting calls cold in BPI

[Meador Inge]

On 11/08/2013 02:33 PM, Hal Finkel wrote:

>> Okay, thanks! (Maybe this leaves me with InstCombine?) Does anything
>> else use, or is expected to use, the cold attribute directly in
>> addition to BPI? If not, maybe leaving this in BPI is just as good
>> as anything else.
> 
> Chandler, please express an opinion. Would you want this in InstCombine? Thanks!

If it needs to be in InstCombine (which seems reasonable if you can't put it in
FunctionAttrs), then you can probably adjust some of the simplifiers in
SimplifyLibCalls or add new simplifiers if needed to add the attributes.  There
is already one simplifier there (StrToOpt) that just adjusts attributes.  The
majority of other cases which solely update attributes are in the FunctionAttrs
pass that was discussed earlier in this thread.

-- 
Meador Inge
CodeSourcery / Mentor Embedded