[PATCH] ARMAsmParser permitted p10 and p11 as operands for coprocessor instructions, resulting in ambiguous encodings

Renato Golin renato.golin at linaro.org
Fri Nov 8 00:00:20 PST 2013


On 7 November 2013 10:25, Artyom Skrobov <Artyom.Skrobov at arm.com> wrote:

> CP10/11 are reserved for FP/NEON operations, and are invalid as operands
> for
> the generic coprocessor instructions.
>

It's funny that the ARM ARM states that p0-p15 are accepted, but on the
pseudo-code it states that Coproc_Accepted() cannot be called for p10/p11
(will assert). There should be a warning on the instructions that use
them...

The change looks good to me, though I'd change the word "copro" in the
comment to (at least) "coproc".

cheers,
-renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131108/eb404ab0/attachment.html>


More information about the llvm-commits mailing list