[PATCH] [lld][mach-o] binary reader and writer

[Rui Ueyama]

  Agreed. It feels your approach, having an internal representation which is always 64 bit, would be easier to handle compared to the template.


================
Comment at: lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h:199
@@ +198,3 @@
+bitFieldExtract(uint32_t value, bool isBigEndianBigField, 
+                                        uint8_t firstBit, uint8_t bitCount) {
+  const uint32_t mask = ((1<<bitCount)-1); 
----------------
I think it's not in LLVM coding style. Can you run clang-format on this patch?

================
Comment at: lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h:234
@@ +233,3 @@
+  }
+  else {
+    result.offset     = r0;
----------------
Ditto

================
Comment at: lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp:1
@@ +1,2 @@
+//===- lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp ------------===//
+//
----------------
Hmm, it's hard to tell which code is just moved from MachOWriter and which is newly written.


http://llvm-reviews.chandlerc.com/D2101

BRANCH
  svn

ARCANIST PROJECT
  lld