[llvm] r193874 - Add comments.

[Eric Christopher]

On Mon, Nov 4, 2013 at 10:38 AM, Manman Ren <manman.ren at gmail.com> wrote:

>
>
>
> On Fri, Nov 1, 2013 at 2:46 PM, Eric Christopher <echristo at gmail.com>wrote:
>
>> Thanks for the comments :)
>>
>> Just noticed that the file has _ rather than - in the file name. I think
>> we prefer the latter to the former in llvm.
>>
>
> Hi Eric,
>
> I checked the testing cases for clang and llvm. The majority use "-", but
> some use "_", one example is "inline_invoke.ll".
> Is using "-" rather than "_" something the community tries to enforce on
> newly added files?
> If yes, I can help in that effort as well :)
>
>
Yep. Mostly the _ are holdovers from an earlier time. Don't know if it's
written down anywhere, but I remember when I started on the project Chris
asking me to use - rather than _ for testcases.

-eric


> Manman
>
>
>>
>> -eric
>>
>>
>> On Fri, Nov 1, 2013 at 11:06 AM, Manman Ren <manman.ren at gmail.com> wrote:
>>
>>> Author: mren
>>> Date: Fri Nov  1 13:06:25 2013
>>> New Revision: 193874
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=193874&view=rev
>>> Log:
>>> Add comments.
>>>
>>> Modified:
>>>     llvm/trunk/test/Transforms/Inline/inline_invoke_with_asm_call.ll
>>>
>>> Modified:
>>> llvm/trunk/test/Transforms/Inline/inline_invoke_with_asm_call.ll
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Inline/inline_invoke_with_asm_call.ll?rev=193874&r1=193873&r2=193874&view=diff
>>>
>>> ==============================================================================
>>> --- llvm/trunk/test/Transforms/Inline/inline_invoke_with_asm_call.ll
>>> (original)
>>> +++ llvm/trunk/test/Transforms/Inline/inline_invoke_with_asm_call.ll Fri
>>> Nov  1 13:06:25 2013
>>> @@ -1,6 +1,8 @@
>>>  ; RUN: opt < %s -inline -S | FileCheck %s
>>>  target triple = "x86_64-apple-darwin"
>>>
>>> +; In inliner, we assume that inline asm does not throw. This testing
>>> case makes
>>> +; sure that the inliner does not convert "call asm" to "invoke asm".
>>>  ; rdar://15317907
>>>  ; CHECK-LABEL: @caller
>>>  ; Make sure we are generating "call asm" instead of "invoke asm".
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131104/568b8aaf/attachment.html>