[patch] Remove linkonce_odr_auto_hide
clattner at apple.com
Thu Oct 31 20:07:03 PDT 2013
On Oct 31, 2013, at 7:46 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> linkonce_odr_auto_hide was in incomplete attempt to implement a way
> for the linker to hide symbols that are known to be available in every
> TU and whose addresses are not relevant for a particular DSO.
> It is redundant in that it all its uses are equivalent to
> linkonce_odr+unnamed_addr. Unlike those, it has never been connected
> to clang or llvm's optimizers, so it is effectively dead.
> Given that nothing produces it, the attached patch is hopefully OK. It
> just nukes it completely. If there are out of tree users I can add
> code to upgrade it to linkonce_odr + unnamed_addr.
I'm in favor of removing dead code, but please don't renumber any enums in the C API - just mark that enum value as dead. Thanks Rafael,
More information about the llvm-commits