[PATCH] [ARM] Add Virtualization subtarget feature and add more build attributes in this area.

[Kristof Beyls]

I think it might be a good idea to completely restructure
the test test/CodeGen/ARM/2010-10-19-mc-elf-objheader.ll.

I think it would be best if that test would only test that
specific build attributes are encoded correctly. Now that
the integrated assembler should be able to parse .eabi_attribute
directives; it should be possible to rewrite the test so that
the inputs are assembly files using the .eabi_attribute?
That way the test would check if the attributes are encoded
correctly; and it would no longer check if the correct
default attributes are generated for specific processors.

Instead, test CodeGen/ARM/2010-09-29-mc-asm-header-test.ll
already checks whether the correct default build attributes
are generated for the different processors.

I think that rewrite would make it easier to understand and
maintain test test/CodeGen/ARM/2010-10-19-mc-elf-objheader.ll.

Thanks,

Kristof


> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Bradley Smith
> Sent: 31 October 2013 12:48
> To: Bradley Smith; t.p.northover at gmail.com
> Cc: llvm-commits at cs.uiuc.edu
> Subject: [PATCH] [ARM] Add Virtualization subtarget feature and add more build
> attributes in this area.
> 
> This change adds a Virtualization ARM subtarget feature along with adding
> proper build attribute emission for Tag_Virtualization_use (encodes
> Virtualization and TrustZone) and Tag_MPextension_use.
> 
> http://llvm-reviews.chandlerc.com/D2078
> 
> Files:
>   lib/Target/ARM/ARM.td
>   lib/Target/ARM/ARMAsmPrinter.cpp
>   lib/Target/ARM/ARMBuildAttrs.h
>   lib/Target/ARM/ARMSubtarget.cpp
>   lib/Target/ARM/ARMSubtarget.h
>   test/CodeGen/ARM/2010-09-29-mc-asm-header-test.ll
>   test/CodeGen/ARM/2010-10-19-mc-elf-objheader.ll