[PATCH] [Sanitizer] Add Symbolizer::AddHooks() and use it in TSan and MSan.

Alexey Samsonov samsonov at google.com
Wed Oct 30 15:33:18 PDT 2013


  > Do we still need SymbolizerScope in msan.h ?

  Yeah, it's used here :(
    if (!fast) {
      // Block reports from our interceptors during _Unwind_Backtrace.
      SymbolizerScope sym_scope;
      return stack->SlowUnwindStack(pc, max_s);
    }


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer.cc:45
@@ +44,3 @@
+                          Symbolizer::EndSymbolizationHook end_hook) {
+  start_hook_ = start_hook;
+  end_hook_ = end_hook;
----------------
Evgeniy Stepanov wrote:
> check that we are not calling this twice
Done


http://llvm-reviews.chandlerc.com/D2067



More information about the llvm-commits mailing list