[patch][cmake] Check if plugin-api.h provides LDPT_GET_SYMBOLS_V2

Nick Lewycky nicholas at mxc.ca
Wed Oct 30 14:10:53 PDT 2013


Rafael EspĂ­ndola wrote:
> ping

This is a departure. Previously our policy has been that users may need 
an arbitrarily recent plugin-api.h, possibly even including someone 
committing to the binutils and llvm repos at the same time.

What's the new rule here? And has binutils changed their policy at all 
(I'm guessing not since this is just a cmake check.)

Also, configure+make system check? :)

Nick

> On 4 October 2013 12:40, Rafael EspĂ­ndola<rafael.espindola at gmail.com>  wrote:
>> LDPT_GET_SYMBOLS_V2 was added back in 2011, but it looks like there
>> are still versions of plugin-api.h out there that don't have it.
>>
>> This patch adds a cmake check so that we degrade gracefully with old versions.
>>
>> I will write an autoconf version too, but I would like to get this one
>> reviewed first. In particular, I would like to know what you think
>> about adding gold-config.h.cmake. I like it because at least with
>> cmake it lets us keep all the changes in tools/gold.
>>
>> Cheers,
>> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list