[PATCH] [AArch64] Make FP instructions optional

[Tim Northover]

  Hi Amara,

  Thanks for doing the updates. I think it's looking quite a bit better now. I just spotted a few issues in the tests, I think.

  Cheers.

  Tim.


================
Comment at: test/CodeGen/AArch64/variadic.ll:40-41
@@ -38,1 +39,4 @@
 
+define void @test_simple_nofp(i32 %n, ...) {
+; CHECK-NOFP-LABEL: test_simple_nofp:
+; CHECK-NOFP: sub sp, sp, #[[STACKSIZE:[0-9]+]]
----------------
This is another duplicated function isn't it? As with more in this file.

================
Comment at: test/CodeGen/AArch64/variadic.ll:139-141
@@ +138,5 @@
+  call void @llvm.va_start(i8* %addr)
+; FP-NOT: sub sp, sp
+; FP: mov [[STACK:x[0-9]+]], sp
+; FP: str [[STACK]], [{{x[0-9]+}}, #:lo12:var]
+
----------------
This is the wrong prefix now. It's not being checked.

================
Comment at: test/MC/AArch64/basic-a64-instructions.s:1
@@ -1,2 +1,2 @@
-// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding < %s | FileCheck %s
+// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+fp-armv8 < %s | FileCheck %s
   .globl _func
----------------
Is this -mattr needed? I really hope not...


http://llvm-reviews.chandlerc.com/D2052