[llvm-commits] [llvm] r162525 - in /llvm/trunk/lib/DebugInfo: DWARFDebugInfoEntry.cpp DWARFFormValue.cpp

[Alexey Samsonov]

On Tue, Oct 29, 2013 at 5:06 AM, Timur Iskhodzhanov <timurrrr at google.com>wrote:

> [and now to the right Eric's address]
>
> 2013/10/29 Timur Iskhodzhanov <timurrrr at google.com>:
> > 2012/8/24 Eric Christopher <echristo at apple.com>:
> >> +++ llvm/trunk/lib/DebugInfo/DWARFFormValue.cpp Thu Aug 23 20:14:23 2012
> >> @@ -67,6 +71,10 @@
> >>    8, // 0x14 DW_FORM_ref8
> >>    0, // 0x15 DW_FORM_ref_udata
> >>    0, // 0x16 DW_FORM_indirect
> >> +  8, // 0x17 DW_FORM_sec_offset
> >> +  0, // 0x18 DW_FORM_exprloc
> >> +  0, // 0x19 DW_FORM_flag_present
> >> +  8, // 0x20 DW_FORM_ref_sig8
> >>  };
> >>
> >>  const uint8_t *
> >
> > Eric,
> > Are you sure it should be 0x20, not 0x1a?
>

This is hilarious. DWARF4 standard indeed specifies 0x20, which is way
confusing and means our code was broken.
I've fixed this in r193619. Thanks for noticing this!


> > --
> > Timur
>



-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131029/5179e99a/attachment.html>