[lld] r193565 - [PECOFF] Fix __ImageBase symbol.

[Shankar Easwaran]

On 10/28/2013 11:32 PM, Rui Ueyama wrote:
> On Mon, Oct 28, 2013 at 9:16 PM, Shankar Easwaran
> <shankare at codeaurora.org>wrote:
>
>> Hi Rui,
>>
>> This is an incorrect subclass of SimpleFile. The MemberFile wouldnot
>> return an empty vector of absoluteAtoms when absolute() is called.
>>
> Do you mean that the MemberFile should not return an empty vector of
> AbsoluteAtoms, but it will return an empty symbol, and that's the problem?
> If so, I'd think the code is not wrong. MemberFile will actually return a
> non-empty vector for absolute(), because _imageBase is added by addAtom()
> in the MemberFile's initializer.
With ELF, we need a similiar thing, so what we do is create a 
RuntimeFile and add atoms to it.

May be that approach could be followed here, feel its more cleaner that way.

Thanks

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation