[PATCH] [PassManager] add calls to RoundTrip{YAML, Native} Reader/Writer

Shankar Kalpathi Easwaran shankarke at gmail.com
Mon Oct 28 21:00:17 PDT 2013



================
Comment at: lib/Passes/RoundTripNativePass.cpp:43
@@ +42,3 @@
+
+  llvm::sys::fs::remove(tmpNativeFile.str());
+}
----------------
Rui Ueyama wrote:
> Instead of removing the file at the end of the function, you should use llvm::FileRemover for RAII-style temporary file management.
No we shouldnt be using FileRemover here, as if there is a problem with the native file or the yaml file, it can be seperately debugged very easily.

================
Comment at: lib/Passes/RoundTripYAMLPass.cpp:43
@@ +42,3 @@
+
+  llvm::sys::fs::remove(tmpYAMLFile.str());
+}
----------------
Shankar Kalpathi Easwaran wrote:
> Rui Ueyama wrote:
> > Ditto
> ?
same as above.


http://llvm-reviews.chandlerc.com/D2047



More information about the llvm-commits mailing list