[PATCH] [ARM] Implement eabi_attribute, cpu, and fpu directives.

Logan Chien tzuhsiang.chien at gmail.com
Sun Oct 27 01:18:15 PDT 2013



================
Comment at: test/CodeGen/ARM/2010-10-19-mc-elf-objheader.ll:258
@@ +257,3 @@
+; CORTEX-R5-NEXT:   0020: 0109020A 04140115 01170318 0119012C
+; CORTEX-R5-NEXT:   0030: 02
+; CORTEX-R5-NEXT: )
----------------
Richard Barton wrote:
> One last problem - the R5 has been specified incorrectly and shouldn't support the ARM divide extension. So Tag_DIV_use should not be emitted, or emitted with value 0. I think just correcting the definition of R5 in ARM.td ought to just sort this out though.
Do you mean that R5 does not support **ARM** hardware division extension?  Does cortex-r5 support **Thumb2** hardware division?  From the commit history, it seems that cortex-r5 should support Thumb2 hardware division.  Thus, I didn't remove FeatureHWDiv from ProcR5.

I have removed FeatureHWDivARM from ProcR5 in new revision, however, the change breaks test/CodeGen/ARM/div.ll.  It seems reasonable for me to change this test case to use soft-fp if cortex-r5 does not support ARM hardware division extension.  Any comments?


http://llvm-reviews.chandlerc.com/D1987



More information about the llvm-commits mailing list