[llvm] r193251 - Use address-taken to disambiguate global variable and indirect memops.

[Chandler Carruth]

On Sat, Oct 26, 2013 at 11:53 PM, Shuxin Yang <shuxin.llvm at gmail.com> wrote:

> Also, while I am sure this is the right approach, I made some comments on
>> this patch:
>>
>>
>> http://lists.cs.uiuc.edu/**pipermail/llvm-commits/Week-**
>> of-Mon-20131021/192186.html<http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20131021/192186.html>
>>
>> it looks like you committed without replying or acting on any of my
>> review comments? Huh?
>>
>>  I somehow miss this mail.  There is no reason to ignore any response. I
> have never ever
> ignore feedback before. Actually I'm expecting your feedback as you are
> original author of the globalopt.


Just a note to help future code reviews Shuxin:

It feels like you're approaching the review a bit wrong. Missing an email
with further comments shouldn't lead you to commit anything. The idea is
that once you start code review, you're waiting for a reviewer to give an
explicit 'LGTM' before you commit.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131027/26f664b4/attachment.html>