[lld] r193362 - Revert "r193300 - [PassManager] add ReaderWriter{Native, YAML} to the Driver"

[Shankar Easwaran]

On 10/25/2013 1:20 PM, Rui Ueyama wrote:
> On Thu, Oct 24, 2013 at 11:12 PM, Shankar Easwaran
> <shankare at codeaurora.org>wrote:
>
>> Hi Rui, All,
>>
>> I mirror Chandlers thought that we really dont want to go in the path of
>> adding these passes from each flavor, as thats only a change which would be
>> removed by subsequent commits.
>>
>> Meanwhile, I have fixed all the tests across all flavors except the same
>> failure across two different tests in pecoff.
>>
>> The test is drective.test/dynamic.test which is failing to create the
>> entries in the Import table :-
>>
>> <------------snip-------------**------>
>> The Import Tables:
>>    lookup 00002068 time 00000000 fwd 00000000 name 000020a4 addr 00002088
>>
>>      DLL Name: vars.dll
>>      Hint/Ord  Name
>>             0  _name_with_underscore
>>             1  fn
>> <------------snip-------------**------>
>>
>> Can you take a look into that ? I have debugged that for a while and cant
>> find a solution. On first thought I think there need to be seperate types
>> for the derived atoms from the IDataAtom, and the Writer need to seperately
>> handle writing of these atoms.
>>
>> We could need to disable 2 of these tests that fail due to the same issue,
>> so that you can look into the failure, after the changes are committed
>> which fixes all the other failures(Sent a review request --
>> http://llvm-reviews.chandlerc.**com/D2022<http://llvm-reviews.chandlerc.com/D2022>
>> )
>>
> Please do not submit the change that breaks tests. We need to keep the tree
> always healthy. I will apply the patch locally and try to fix the test
> failure myself, so please hold on.

Thanks Ruiu for helping out here. You would need to apply all these 
fixes and the RoundTrip Patch too.

Could you review the changes contained in D2022 and let me know, I can 
submit the changes to the RoundTrip patch after you verify that things 
are working for you with that. I will wait until you give me a green 
light on that.

Thanks

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation