[PATCH] [bugpoint] Increase the default memory limit for subprocesses to 300MB.

[Daniel Sanders]

No problem. I was trying out the likely reviewers feature ('arc cover') of phabricator.

> -----Original Message-----
> From: jyasskin at google.com [mailto:jyasskin at google.com] On Behalf Of
> Jeffrey Yasskin
> Sent: 24 October 2013 16:48
> To: reviews+D2013+public+4f36bb97834176c2 at llvm-reviews.chandlerc.com
> Cc: Daniel Sanders; Commit Messages and Patches for LLVM
> Subject: Re: [PATCH] [bugpoint] Increase the default memory limit for
> subprocesses to 300MB.
> 
> I'm not the right person to review this, sorry.
> 
> On Thu, Oct 24, 2013 at 5:47 AM, Daniel Sanders
> <daniel.sanders at imgtec.com> wrote:
> > Hi jyasskin,
> >
> > Currently shared library builds (BUILD_SHARED_LIBS=ON in cmake) fail
> > three bugpoint tests (BugPoint/remove_arguments_test.ll,
> > BugPoint/crash-narrowfunctiontest.ll, and BugPoint/metadata.ll).
> >
> > If I run the bugpoint commands that llvm-lit runs with without
> > -silence-passes I see errors such as this:
> >     opt: error while loading shared libraries: libLLVMSystemZInfo.so: failed to
> >     map segment from shared object: Cannot allocate memory
> >
> > It seems that the increased size of the binaries in a shared library
> > build is causing the subprocess to exceed the 100MB memory limit. This
> > patch therefore increases the default limit to a level at which these tests
> pass.
> >
> > http://llvm-reviews.chandlerc.com/D2013
> >
> > Files:
> >   tools/bugpoint/bugpoint.cpp
> >
> > Index: tools/bugpoint/bugpoint.cpp
> >
> ==========================================================
> =========
> > --- tools/bugpoint/bugpoint.cpp
> > +++ tools/bugpoint/bugpoint.cpp
> > @@ -49,8 +49,8 @@
> >
> >  static cl::opt<int>
> >  MemoryLimit("mlimit", cl::init(-1), cl::value_desc("MBytes"),
> > -             cl::desc("Maximum amount of memory to use. 0 disables check."
> > -                      " Defaults to 100MB (800MB under valgrind)."));
> > +            cl::desc("Maximum amount of memory to use. 0 disables check."
> > +                     " Defaults to 300MB (800MB under valgrind)."));
> >
> >  static cl::opt<bool>
> >  UseValgrind("enable-valgrind",
> > @@ -152,7 +152,7 @@
> >      if (sys::RunningOnValgrind() || UseValgrind)
> >        MemoryLimit = 800;
> >      else
> > -      MemoryLimit = 100;
> > +      MemoryLimit = 300;
> >    }
> >
> >    BugDriver D(argv[0], FindBugs, TimeoutValue, MemoryLimit,
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >