[PATCH] Support for microMIPS jump instructions

Jack Carter Jack.Carter at imgtec.com
Thu Oct 24 12:50:12 PDT 2013


Patches,  compiles and tests fine.

def TAILCALL64_R : JumpFR<"tcallr", GPR64Opnd, MipsTailCall>, MTLO_FM<8>, IsTailCall;
line too long= 162 len= 85 lib/Target/Mips/Mips64InstrInfo.td

I'd also like to see more function/method headers. The header should be with the declaration and not the definition unless they are the same as in the case of some static functions.

+  unsigned getJumpTargetOpValueMM(const MCInst &MI, unsigned OpNo,
+                                  SmallVectorImpl<MCFixup> &Fixups) const;
+

+  unsigned getJumpTargetOpValueMM(const MachineInstr &MI, unsigned OpNo) const;

Other than that, LFTM. Remember to include the new files when committing.

Jack

________________________________
From: Zoran Jovanovic
Sent: Thursday, October 24, 2013 4:26 AM
To: llvm-commits at cs.uiuc.edu
Cc: Jack Carter; Jozef Kolek
Subject: [PATCH] Support for microMIPS jump instructions

Patch adds support for microMIPS jump instructions.

Zoran Jovanovic
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131024/ac48db15/attachment.html>


More information about the llvm-commits mailing list