[lld] r193300 - [PassManager] add ReaderWriter{Native, YAML} to the Driver.

[Shankar Easwaran]

On 10/24/2013 1:57 AM, Michael Spencer wrote:
> On Wed, Oct 23, 2013 at 10:23 PM, Rui Ueyama <ruiu at google.com> wrote:
>
>> I did not expect you were going to submit your change with disabling so
>> many tests. It disabled even pretty basic tests for COFF. This is really
>> bad. Please don't do that.
>>
>> I strongly suggest reverting this patch. You need to fix the tests before
>> submitting the change.
>>
> Yeah, this needs a revert. I thought you were just marking what needs to be
> fixed before commit.

I am planning to go and fix the ELF changes as there are some 
implementations that have been left out in pecoff code.

Flavors were also assuming certain things which have to be handled 
seperately after this commit.

As far as I see, this just uncovered issues in flavors. I dont see a 
problem with the patch.

Thanks

Shankar Easwawran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation