[PATCH] Quick look-up for block in loop

[Hal Finkel]

----- Original Message -----
> 
>   Hal:
> 
>   Thanks for your comments, I don't think the DenseSet could be
>   cached since the blocks in loop may be changed.


I think that, normally, blocks can't be added or removed from a loop without either invalidating the LoopInfo, or updating it (calling LoopInfo::removeBlock, changeLoopFor, etc.). I think that to get a mutable copy of the blocks array directly, getBlocksVector needs to be called (and it could invalidate the cache, and prevent further caching after it is called).

> 
>   Finally, when you post patches to llvm-reviews, please generate
>   them with -U999999 so that we can see the full context in the web
>   interface.
>   ~~~~What diff tool do you usually use, it seems svn diff has no
>   option -U999999, thanks.

http://llvm.org/docs/Phabricator.html says:

svn diff --diff-cmd=diff -x -U999999

Personally, I use git-svn, so it is a bit easier.

Thanks,
Hal

> 
> 
>   Thanks
>   Wan Xiaofei
> 
> http://llvm-reviews.chandlerc.com/D2014
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory