[PATCH] Add a "split-stack" function attribute.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Tue Oct 22 20:09:27 PDT 2013


  This is going in the right direction.

  Sorry for taking so long to review.


================
Comment at: include/llvm/CodeGen/CommandFlags.h:194
@@ -193,3 +193,3 @@
 
-cl::opt<bool>
+cl::opt<llvm::SplitStacks::SplitStacksMode>
 SegmentedStacks("segmented-stacks",
----------------
Why do you need this option? The point of having a positive attribute (split-stack)  attribute is that we can remove the existing codegen option.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:10743
@@ +10742,3 @@
+  if (!Lower) {
+    const TargetLowering &TLI = DAG.getTargetLoweringInfo();
+    SDNode* Node = Op.getNode();
----------------
Can't you call ExpandDYNAMIC_STACKALLOC?


http://llvm-reviews.chandlerc.com/D1905



More information about the llvm-commits mailing list