PATCH: Inliner: Don't generate memcpy calls for byval readonly parameters

Nick Lewycky nlewycky at google.com
Tue Oct 22 15:20:36 PDT 2013


On 22 October 2013 15:11, Chandler Carruth <chandlerc at google.com> wrote:

> This looks fine, but Nick should confirm that it is the correct
> implementation of byval & readonly.
>

I don't deeply understand 'byval', but this patch looks like it can't
possibly be wrong.

On Tue, Oct 22, 2013 at 3:07 PM, Tom Stellard <tom at stellard.net> wrote:
>
>> Hi,
>>
>> The function inliner avoids generating memcpy calls when the parameter
>> is marked byval and the function is marked readonly.  The attached
>> patch extends this behavior to the case where the function parameter is
>> readonly, but the function isn't.
>>
>> Please review.
>>
>> Thanks,
>> Tom
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131022/ea56205f/attachment.html>


More information about the llvm-commits mailing list