[PATCH] Changed loop variable from int to uint32_t in llvm-cov

Bob Wilson bob.wilson at apple.com
Tue Oct 22 13:08:49 PDT 2013


I don't think there is a real problem with overflow here because the loop exit conditions are using != comparisons.  Even if the int values overflow, that should not change the behavior of those comparisons.  (It would be different for less-than and greater-than comparisons.)  But, I've applied your patch anyway since it makes sense to be consistent with the types used for the loop bounds.  r193192

On Oct 22, 2013, at 10:52 AM, Yuchen Wu <yuchenericwu at hotmail.com> wrote:

> Changed a couple of loop variables in llvm-cov to uint32_t when the condition statement contains a comparison to uint32_t.
> <0005-Changed-index-variable-from-int-to-uint32_t.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131022/8f858180/attachment.html>


More information about the llvm-commits mailing list