[PATCH][ARM] Fix .thumb_func directive in ARMAsmParser

Gabor Ballabas gaborb at inf.u-szeged.hu
Tue Oct 22 10:32:36 PDT 2013


This patch is intended to solve the following FIXME in
ARMAsmParser::parseDirectiveThumbFunc:

  // FIXME: assuming function name will be the line following .thumb_func
  // We really should be checking the next symbol definition even if there's
  // stuff in between.

I didn't add any new test just modified the existing one by moving the
.type directive between the .thumb_func directive
and the actual symbol (you can check it in the diff). This is how GCC
places the directives (at least it did it for me when
I compiled  a simple "Hello world!" C program to assembly code).

I'm looking forward to any suggestion.

Best regards,
Gabor Ballabas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131022/631073ba/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: thumb_func.patch
Type: text/x-patch
Size: 4294 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131022/631073ba/attachment.bin>


More information about the llvm-commits mailing list