[llvm] r187963 - Make sure that if we're going to attempt to add a type to a DIE that

Eric Christopher echristo at gmail.com
Mon Oct 21 11:52:46 PDT 2013


I've done most of these in r193095.

>>
>> +  // If this is an array type verify that we have a DIType in the derived
>> type
>> +  // field as that's the type of our element.
>
>
> This seems rather narrow. Is this the exception moreso than the rule (ie:
> most DICompositeTypes don't require a type they're derived from?)
>
> And shouldn't this check be up in DIDerivedType? (is an array even a
> DICompositeType? I wonder why it's not just a DIDerivedType)
>

I think because it already was up in DIDerivedType? *shrug* At any
rate it is now. Sorry for the delay here.

And array type was composite because it's a container of things I
imagine - predates me, don't think it really matters.

-eric



More information about the llvm-commits mailing list