[PATCH] WIP Implement eabi attributes handling in ARMAsmParser

[Rafael Espíndola]

Thank you so much for working on this!

Can AttributeEmitter be merged into the target asm streamer? I.E. just
add the MaybeSwitchVendor, EmitAttribute, EmitTextAttribute and Finish
to the target streamer.

+  // Maps for ARM build attributes.
+  std::map<unsigned, unsigned> AttributeMap;

What is the range of these integers? There is almost certainly a
better data structure for doing this. Why is this on the parser? Can't
the parser just call EmitAttribute for very .eabi_attribute and let
the streamer handle it?



On 18 October 2013 09:21, Gabor Ballabas <gaborb at inf.u-szeged.hu> wrote:
> This is a work-in-progress patch for this bug:
> http://llvm.org/bugs/show_bug.cgi?id=15172
> This patch only handles the .eabi_attribute directive but I can make the
> .cpu, .fpu and .arch
> directives work as well with a similar approach.
>
> Best regards,
> Gabor Ballabas
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>