[PATCH] MC asm parser: allow @'s in symbol names in MS assembly

Hans Wennborg hans at chromium.org
Fri Oct 18 11:55:20 PDT 2013



================
Comment at: lib/MC/MCParser/AsmParser.cpp:2129
@@ -2122,2 +2128,3 @@
+    if (PrefixLoc.getPointer() + 1 != getTok().getLoc().getPointer())
       return true;
 
----------------
David Majnemer wrote:
> Should this be gated on `doesAllowAtInName`?
I don't know, we already allow @'s in names during parsing. This just allows them as the initial character, and I don't think this introduces any ambiguity.

The doesAllowAtInName() is more like "is the @ part of the name for realz, or does it signify the separator between the name and PLT/GOT/etc".

If we gate it here, we'd have to gate it in the switch in parsePrimaryExpr() too.


http://llvm-reviews.chandlerc.com/D1978



More information about the llvm-commits mailing list