[PATCH] [lld] add calls to nativereader/nativewriter

Shankar Kalpathi Easwaran shankarke at gmail.com
Thu Oct 17 20:17:56 PDT 2013



================
Comment at: include/lld/Core/Resolver.h:85
@@ -83,3 +84,3 @@
 
-  class MergedFile : public MutableFile {
+  class MergedFile : public SimpleFile {
   public:
----------------
Rui Ueyama wrote:
> This change makes SimpleFile class the sole child class of MutableFile. I'd merge them into one class to reduce the number of classes and complexity.
I am planning to put the old interface back.

================
Comment at: include/lld/Passes/RoundTripNativePass.h:10
@@ +9,3 @@
+
+#ifndef LLD_PASSES_NATIVE_PASS_H
+#define LLD_PASSES_NATIVE_PASS_H
----------------
Rui Ueyama wrote:
> This should be LLD_PASSES_ROUND_TRIP_NATIVE_PASS_H.
ok.

================
Comment at: include/lld/Passes/RoundTripYAMLPass.h:10
@@ +9,3 @@
+
+#ifndef LLD_PASSES_ROUNDTRIP_YAML_PASS_H
+#define LLD_PASSES_ROUNDTRIP_YAML_PASS_H
----------------
Rui Ueyama wrote:
> This should be LLD_PASSES_ROUND_TRIP_YAML_PASS_H.
ok.

================
Comment at: lib/Driver/Driver.cpp:130
@@ -117,1 +129,3 @@
 
+  lld::File *resultFile = &merged;
+
----------------
Rui Ueyama wrote:
> Why do you need this temporary variable?
need to be removed.


http://llvm-reviews.chandlerc.com/D1955



More information about the llvm-commits mailing list