[PATCH] DebugInfo: Introduce the notion of "form classes"

David Blaikie dblaikie at gmail.com
Thu Oct 17 11:38:03 PDT 2013



================
Comment at: include/llvm/DebugInfo/DWARFFormValue.h:23
@@ -22,3 +22,3 @@
   struct ValueType {
-    ValueType() : data(NULL), IsDWOIndex(false) {
       uval = 0;
----------------
Is this change separable? It looks like it could be. (if so, please commit or send for separate review)

================
Comment at: lib/DebugInfo/DWARFFormValue.cpp:483
@@ -482,3 +533,1 @@
 
-const uint8_t *DWARFFormValue::BlockData() const {
-  if (!isInlinedCStr())
----------------
These 3 functions are just dead code? Please remove them separately if that's the case.


http://llvm-reviews.chandlerc.com/D1961



More information about the llvm-commits mailing list