[PATCH] [lld] add calls to nativereader/nativewriter

[Rui Ueyama]

On Wed, Oct 16, 2013 at 12:48 PM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

>
>   The native file is written only in DEBUG mode. This was also previously
> discussed to make sure the performance is not hampered in release mode.


Yes, I know that. What I asked is how much performance impact it would
have. If it's significant, we don't want to always enable that even in
DEBUG mode.

================
> Comment at: lib/Driver/Driver.cpp:143
> @@ +142,3 @@
> +  resultFile = nativeFile[0].get();
> +#endif
> +
> ----------------
> Rui Ueyama wrote:
> > This should be a separate function for readability.
> Ok.
>
> ================
> Comment at: test/elf/X86_64/dontignorezerosize-sections.test:6
> @@ -5,3 +5,2 @@
>
> -CHECK:    section-name:    .data
>  CHECK:    references:
> ----------------
> Rui Ueyama wrote:
> > Why do these test result change? This change shouldn't change the result
> right?
> The atom is set to the default section.
>
> typeCode->.text
> typeData->.data and so on.
>
>
>
> http://llvm-reviews.chandlerc.com/D1955
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131016/b0e6b236/attachment.html>