[PATCH] [lld] add calls to nativereader/nativewriter

Rui Ueyama ruiu at google.com
Wed Oct 16 12:44:00 PDT 2013


  Going through the native format may be a good idea, but how much performance impact it would have? If it visibly slows down the linking time, we don't want to do that even behind NDEBUG but instead have a separate flag to enable.


================
Comment at: lib/Driver/Driver.cpp:143
@@ +142,3 @@
+  resultFile = nativeFile[0].get();
+#endif
+
----------------
This should be a separate function for readability.

================
Comment at: test/elf/X86_64/dontignorezerosize-sections.test:6
@@ -5,3 +5,2 @@
 
-CHECK:    section-name:    .data
 CHECK:    references:      
----------------
Why do these test result change? This change shouldn't change the result right?


http://llvm-reviews.chandlerc.com/D1955



More information about the llvm-commits mailing list