[PATCH] Make some pthread_mutex_* and pthread_cond_* interceptors common.

Dmitry Vyukov dvyukov at google.com
Tue Oct 15 23:04:10 PDT 2013


  LGTM in the sense that I can't think of a better way to do it

  thinking aloud, I do not like that our logic becomes macro/casting-dominant:
  #define COMMON_INTERCEPTOR_MUTEX_LOCK(ctx, m) \
    MutexLock(((TsanInterceptorContext *)ctx)->thr, \
              ((TsanInterceptorContext *)ctx)->pc, (uptr)m)
  later when we need to hook into before mutex lock (for deadlock detector, sched shaking), the important logic will be shredded on top of that...

http://llvm-reviews.chandlerc.com/D1937

BRANCH
  svn

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list