[PATCH] COFF MC: better handling of tricky symbol and section names

Reid Kleckner rnk at google.com
Tue Oct 15 17:48:28 PDT 2013


  LGTM


================
Comment at: lib/MC/MCParser/AsmParser.cpp:798
@@ +797,3 @@
+    
+    if (FirstTokenKind != AsmToken::String && Identifier.count('@')) {
+      std::pair<StringRef, StringRef> Split = Identifier.split('@');
----------------
No need to scan twice, the split is cheap.


http://llvm-reviews.chandlerc.com/D1945



More information about the llvm-commits mailing list