[llvm] r192316 - llvm-c: Make target initializer functions external functions in lib.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Oct 14 17:30:26 PDT 2013


> Yes. building worked fine (linux amd64 ubuntu). But "make check"
> failed when doing -DBUILD_SHARED_LIBS=1, but it failed also without my
> patch. Also tried building on mingw32 using autoconf, and that also
> built.
>
> Locally I have renamed the new library to "AllTargetsBindings", as
> "AllTargets" meant that it was named "alltargets" in llvm-config,
> which probably is a bit to close to the "all-targets".

Yes, the make check failure is another problem (I just emailed a patch
that fixes it).

Your patch LGTM.

Cheers,
Rafael



More information about the llvm-commits mailing list