[PATCH] [msan] Instrument x86.*_cvt* intrinsics.

Alexander Potapenko glider at google.com
Mon Oct 14 07:35:20 PDT 2013


  LGTM with nits.


================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:1593
@@ -1577,3 +1592,3 @@
     }
 
 
----------------
Please remove a spare newline.

================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:898
@@ +897,3 @@
+  void insertShadowCheck(Value *Shadow, Value *Origin,
+                            Instruction *OrigIns) {
+    assert(Shadow);
----------------
Please fix the indentation.


http://llvm-reviews.chandlerc.com/D1898



More information about the llvm-commits mailing list